He previously played for Salford Red Devils in the Super League and both Melbourne Storm and Brisbane Broncos as a scrum-half in the NRL.

[3] He played his junior rugby league for the Highfields Eagles and was a member of the 2014 Churchie First XV alongside Kalyn Ponga, and Jaydn Su'a[4] before being signed by the Melbourne Storm.

[7][8] On 22 May, he made his Queensland Cup debut with Melbourne's feeder team, the Easts Tigers, scoring a try in their 52-20 win over the Ipswich Jets.

[12] In just his second NRL game, he slotted an extra-time field goal to secure victory over North Queensland and in doing so, Melbourne escaped with a 23-22 win in golden-point.

[13] On 24 July, he signed a contract extension with the Storm, tying him to the club for at least another three years with a view to replacing Cooper Cronk in the long-term as Melbourne's halfback.

[20][21] Croft endured a difficult first year in Brisbane and played 14 games for the club as they finished last on the table and claimed the wooden spoon.

"[citation needed] In Round 1 of the 2022 Super League season, Croft made his club debut for Salford in their 26-16 victory over Castleford.

Croft guided Salford to play-off finish and was instrumental in securing the teams preliminary finals spot after a comprehensive victory away at Huddersfield.

[26] In the 2023 Super League season, Croft played 25 matches for Salford as the club finished 7th on the table and missed the playoffs.