He was the head coach of the Virginia Tech Hokies men's basketball team from 1976 until his resignation in October 1987.

Including his time at Tech and coaching stints in high school and at Roanoke College and Tulane University, Moir compiled a career record of 616–238 in his 31 seasons as a high school and college head coach.

Following his college career, Moir played Minor League Baseball with the Cincinnati Reds organization.

[2] After three years in baseball, Moir moved on to coach high school basketball, coaching for eleven years in Stuart, Virginia, Jefferson, North Carolina, and Mount Airy, North Carolina and finishing with a career record of 224–43.

After coaching under Bill Matthews and Howard Shannon for four seasons, Moir moved on to Roanoke College where he compiled a 133–44 record in his six years, winning the NCAA College Division (now called Division II) national championship in 1972.

Moir's first recruit at Roanoke was Frankie Allen, the first African American basketball player in school history, who would eventually follow Moir as the head coach of Virginia Tech and become Virginia Tech's first African American head coach.

[5] In Moir's first season, the Hokies earned a bid to the NIT, but fell in the second round to #12 Alabama.