Following graduation in 1968 he attended Princeton Theological Seminary, New Jersey, USA and served at the First Presbyterian Church, Philadelphia, as Peter Marshall Scholar.
From 1969 until 1975 he was a youth club leader and Assistant Minister, working in Glasgow for the Trinity College Missionary Society.
In 1987 became minister at Renfield St Stephen's Church in the city centre of Glasgow.
He has also taken part in study tours with Christian Aid to the Philippines, Malawi and South Africa.
He was Turnbull Trust preacher at Scots' Church, Melbourne November 2010 to January 2011.