[2] He was appointed from Pennsylvania to the United States Military Academy at West Point, graduating in 1822, 26th in his class of 40.

He distinguished himself during the Mexican–American War under Zachary Taylor, receiving brevet promotions to major for gallantry at Palo Alto and to lieutenant colonel for Resaca de la Palma.

While trying to ascertain his position without his staff officers, he instead met the 47th Virginia, part of General James Longstreet's command.

Previous illness was aggravated by his confinement in prison, and after his exchange (for Simon Bolivar Buckner) in August, McCall resigned due to poor health in March 1863.

He died at his "Belair" estate in West Chester, Pennsylvania, on February 25, 1868, and is buried in the Christ Church Burial Ground in his native Philadelphia.