After making his Football League debut for Swansea Town, his career was interrupted by the outbreak of the Second World War.
He helped the Bluebirds to promotion as Second Division runners-up in the 1951–52 season and began forming a partnership with striker Wilf Grant.
He made his debut for Wales in their first post-war international match, a 3–1 victory over Scotland in October 1946, and won a total of twelve full caps during his career, scoring two goals.
[1][4] In his later years as a Cardiff City player, he began a business career, working part-time for an oil company.
In 1957 he was invited to join the board of directors of Cardiff City, a directorship which he held for twenty-five years in two spells.