[1][2] He is best known for his many poems written for children, as the creator of the Tot Batot character, and as the translator of many poetic works from mostly Persian into Punjabi and Urdu languages.

He earned a master's degree in Persian language from Forman Christian College (FCC) in Lahore, Pakistan.

He worked for and remained with Government College Lahore for his entire career, rising to head the Department of Persian Studies in 1943.

This circle's members included Pakistan's noted literary personalities including Patras Bokhari, Abdul Majeed Salik, Imtiaz Ali Taj, M. D. Taseer, Chiragh Hasan Hasrat, Hafeez Jalandhari, Abdur Rahman Chughtai and Majeed Malik.

[1] His poems were used as the lyrics of several songs sung by Noor Jehan, Naseem Begum, Farida Khanum and Ghulam Ali.