A goalkeeper, he played his club football for Cardiff City and was part of the Wales squad for the 1958 FIFA World Cup in Sweden.
He made his professional debut for Cardiff City in the final match of the 1952–53 season during a 2–0 loss to Aston Villa.
However, he made just 17 appearances during the next two years as he served as understudy to Ron Howells before becoming the club's first choice goalkeeper during the 1955–56 season.
At the end of the season he won the first of his Welsh Cup winners medals after beating Swansea Town 3–2 in the final.
[4] During the 1957–58 he shared the number one goalkeeper spot with Ken Jones before losing his place the following season to Ron Howells, making just one league appearance on the final day of the season but did play in all but one of the sides games in Welsh Cup, beating Lovells Athletic 2–0 in the final.