On 26 January 1841 he was appointed extra aide-de-camp to Major-General William George Keith Elphinstone, and accompanied him to Afghanistan during the First Anglo-Afghan War.

In the latter part of that year he was present at the forcing of the Khoord Cabul pass, and the actions near Kabul, and on 21 December he was given up of his own accord to Akbar Khan as a hostage.

He was released with the other captives on 21 September 1842, joined the force sent into Kohistan under Brigadier M'Caskill, and was present at the capture of Istalif.

He served throughout the Crimea War with the Light Division as assistant quartermaster-general, being present at the Battles of Alma, Balaclava, Inkerman, and the assault on the Redan, and he accompanied the expedition to Kerch.

He was made Knight Commander of the Bath on 2 June 1877, and colonel of the 2nd Battalion, Royal Inniskilling Fusiliers on 13 March 1886, a position he held until his death.