After starting in youth football with his hometown boys club, Motherwell Orbiston, Weir signed professionally with Hamilton Accies in 1987.
Following a knee operation, Weir was preparing to return to first-team action against Aberdeen when he broke his nose (for the sixth time) in a training-ground collision with teammate Paddy Connolly.
[2] After his senior career, Perth-based Weir played Junior football for local sides Bankfoot Athletic, Luncarty and Kinnoull in between managerial appointments.
[10] Weir failed to save Arbroath from relegation in the 2009–10 Scottish Second Division, as they finished ninth and were beaten by Forfar Athletic in the play-offs.
[2] Brechin finished fourth in the 2010–11 Scottish Second Division, qualifying for the promotion play-offs, but lost in the final to Ayr United.