[1] He started his career as an apprentice with Leeds United in June 1961, having impressed in the centre-half position for Barnsley Schoolboys.
[4] They then finished fourth in 1966–67, five points off the summit; Revie began to convert Greenhoff from a winger into a centre-forward.
[4] He turned out against Dinamo Zagreb at Elland Road in the second leg of the 1967 Inter-Cities Fairs Cup final, a goalless draw, Leeds lost the tie 2–0 on aggregate.
He went on to appear in the League Cup final in 1968 after recovering from a knee injury; United beat Arsenal 1–0 thanks to a 20 yards (18 m) strike from Terry Cooper.
[4] Greenhoff went on to score four of Leeds' nineteen goals past minnows CA Spora Luxembourg in the 1967–68 instalment of the Inter-Cities Fairs Cup.
He also appeared as a half-time substitute in the first leg of the final, a 1–0 home win over Ferencvárosi TC, which was enough to secure Leeds the trophy after a goalless draw in Budapest.
He was bought by Birmingham City manager Stan Cullis in August 1968, who paid the Yorkshire club a £70,000 fee.
[4] Greenhoff made a huge impact at Birmingham, scoring fifteen goals in 36 games (in all competitions) as the "Blues" finished 1968–69 seventh in the Second Division.
[7] He hit nine goals in 37 games in 1969–70, a tally beaten by strike partners Harry Burrows and John Ritchie.
[7] In 1970–71 he hit ten goals in 43 games, appearing in Stoke's FA Cup semi-final defeat to eventual winners Arsenal.
[12] He played for the "Potters" at Wembley against Chelsea in the 1972 Football League Cup final, which ended in a 2–1 win for Stoke – the only major trophy in the club's history.
He also helped the club to the FA Cup semi-finals in 1972, his goal at Old Trafford cancelling out George Best's effort and earning Stoke a replay, which they won.
He hit ten goals in 44 games in 1973–74, not including his brace against Hull City in the final of the Watney Cup at the Victoria Ground.
[7] After three goals in sixteen games in 1976–77, he was sold to Tommy Docherty's Manchester United in November 1976 for £120,000; with Stoke needing the money to pay a bill for £250,000 to repair the Victoria Ground following a powerful wind-storm.
He scored 97 goals for Stoke in 338 league and cup starts, putting him ninth in the club's overall goalscoring charts.
He then went on to score the winner in the final after getting in the way of Lou Macari's wayward shot; in doing so he denied opponents and bitter rivals Liverpool the treble.
[13] He was reunited with former boss Tony Waddington, and though Crewe were a struggling Fourth Division side, Greenhoff managed four goals in eleven league games.
He moved to North American Soccer League side Toronto Blizzard in March 1981, then led by Keith Eddy.