Born in Mexborough, West Riding of Yorkshire, Smith played for local non-league sides before signing as an amateur with London club Arsenal in April 1939.
He turned professional that summer, only for World War II to break out; Smith joined the Royal Engineers and served as a sapper, but also played in some wartime matches for Arsenal (17 in all).
Smith made his debut at centre half, deputising for Leslie Compton, in an 8–0 victory over Grimsby Town on 1 May 1948, the final match of their 1947-48 First Division-winning season.
Smith finally gained a regular place at left back, after Scott suffered a series of injuries and Barnes switched sides to cover for him.
He spent a single season at Watford, before moving to Gravesend & Northfleet as manager, where he won the 1957-58 Southern League title.