[3] McBain, a wing half, began his senior football career in the summer of 1914, joining Ayr United,[4] with whom he made his league debut on 20 March 1915 against Clyde.
In January 1923, after 42 league games for United, McBain moved to Everton, costing the Goodison Park side £4,200.
He played 97 league games for Everton, leaving in July 1926 to join St Johnstone[4] for a fee of £1,100.
His Scotland international debut came in April 1922 while he was with Manchester United, in a 1–0 victory against England at Villa Park.
In August 1949, McBain left Orient to manage Argentine side Estudiantes de La Plata.