A combative midfielder, he enjoyed something of a journeyman career, encompassing spells with Motherwell, Dunfermline Athletic (twice), Falkirk, Heart of Midlothian, Ayr United and Berwick Rangers, where he was manager for seven years.
After briefly being attached to both Dundee and Dundee United, Smith first joined Raith Rovers as a player in the season 1982–83, and the following year he was joined by Keith Wright with whom he struck up a potent striking partnership, Smith scoring 34 goals and Wright 25 in 1984–85; the following season Smith notched up 27 goals to Wright's 28.
Two months after his arrival at Shielfield Park, Smith was appointed manager, a post he held until 2004, when he got the club promoted to the Scottish Second Division.
He later performed the role of assistant manager to Des McKeown at Stenhousemuir, until the pair's dismissal in November 2006.
He later worked for Raith Rovers as assistant manager to Grant Murray; he had been assistant to John McGlynn when the club was promoted to the First Division, reached a Scottish Cup semi-final and just missed out on promotion to the SPL.