He made 5 first team appearances for West Bromwich Albion, scoring one goal, before joining Charlton Athletic in February 1968.
He agreed terms with Port Vale in August 1976 but didn't sign for them, instead returning to West Bromwich Albion where he finished his English career.
He then joined the Shamrock Rovers in 1977 under Johnny Giles and in three seasons at Milltown he scored 35 league goals from the 71 games he played in.
He made 3 appearances in European competitions, but was most prominently remembered by Rovers fans when his penalty against Sligo helped win the FAI Cup in 1978.
Controversially he was one of the backers behind the baffling move to install "Dublin City" into the Scottish Second Division in January 1990 despite managing in the League of Ireland at the same time.