His film roles of the 1930s tended towards melodrama, such as the jealous Ernest in Maurice Elvey's The Water Gipsies (1932), and the murderous Eric opposite Matheson Lang in The Great Defender (1934).

Middle-age saw his characters become more affable and his later films showcase his ability at light comedy, such as the sleepy Inspector Sneed in The Door with Seven Locks (1940); the dual role of bumbling Arthur and the Ghost in Don't Take It to Heart (1944); and the dog-obsessed Jennings in Forbidden (1949).

He was a surprise romantic lead in I'll Walk Beside You (1943), and had probably his most high profile role in the ensemble cast of Ealing's supernatural drama The Halfway House (1944).

He continued acting into the 1950s and 1960s, mainly in television series such as Ivanhoe, Probation Officer and Public Eye, as well as small roles in a couple of Anglo-Amalgamated's Edgar Wallace Mysteries films.

He directed the 1938 film version of Edgar Wallace's The Terror, as well as the 1943 stage adaptation of Graham Greene's Brighton Rock at the Garrick Theatre, London.