He played in eight consecutive PGA Cup matches between 1986 and 2000 and was captain of the Great Britain and Ireland team in 2011 and 2013.

Weir won the Scottish Boys' Championship at North Berwick in April 1968, beating Mike Grubb 6&4 in the 36-hole final.

[1] His first 72-hole win came in the 1983 Scottish Coca-Cola Tournament at North Berwick, where he finished with two rounds of 68 to beat David Robertson by a stroke.

At Sandiway in 1987 he won by two strokes from John Hoskison and David Huish, despite taking seven at the par-3 13th in the final round.

[22] Weir competed in the PGA Cup eight consecutive times between 1986 and 2000 and was captain of the Great Britain and Ireland team in 2011 and 2013.

[23] In 2001 he won the TEMES Seniors Open in Greece, a stroke ahead of David Good.