Weaver began his career at local side Pilsley from where he moved to Sutton Town.
[2] In November 1929 he left Anlaby Road for Newcastle United, netting City a huge profit by moving for £2500.
[2] He proved a success at St James' Park, winning an FA Cup medal with the club in 1932.
[2] As a player Weaver was noted not only for aggression but also for his long throw-ins which reached up to 35 yards in length.
He left the club in June 1949 to take up a similar role at Millwall and remained in this position until January 1954.