Born in Dublin, he began his career with youth side Stella Maris before signing for Drumcondra-based Shelbourne, with whom he won the FAI Cup in his second year in the senior team in 1960.
After being released in 1973, he signed for Bolton Wanderers, making another almost 200 appearances in six years, before playing a single season with the Detroit Express in the North American Soccer League in 1979.
[4][3] A week after the final, on 26 April 1960, he was signed by Manchester United for £5,000[5] as cover for Noel Cantwell and Shay Brennan.
His highest honour came as part of the side that won the 1968 European Cup, beating Benfica 4–1 in the final.
[7] He made 535 appearances for Manchester United, behind only Bobby Charlton and Bill Foulkes at the time of his departure in 1973.