He began his career in the youth side for Svitanok Vinnytsia under head coach Sergey Verich, who scored in his first season 25 goals in the Duflo 71[1] and in 2005 signed his first professional contract for FC Kryvbas Kryvyi Rih, here earned his first seven professional matches over two years.

[2] In January 2007 Fedorchuk left Kryvbas Kryvyi Rih and signed for FC Lviv[3] who played 29 games, two Cup Matches and scored three goals.

[4] On 1 March 2010, he joined Ukrainian Premier League side FC Dnipro Dnipropetrovsk for €480,000 transfer fee, but was initially loaned back to Kryvbas.

Valeriy announced the end of playing career on 13 March 2023 after 296[6] total appearances in Ukrainian Premier League.

[7] In June 2011, Fedorchuk married broadcaster Olena Kindzerska, daughter of FC Lviv's President Yuriy Kindzerskyi.