He was born in Collingwood to fireman John Richard Knight and Janet Shirra Wilson.
He served in the Pacific in World War II, and was part of the occupation of Japan.
In 1953 he joined the Labor Party, and the following year became secretary of the Federated Engine Drivers' and Firemen's Association, a position he held until 1963.
In 1963 he was elected in a by-election to the Victorian Legislative Council for Melbourne West Province.
In 1977 he lost preselection to Joan Coxsedge, and he contested the 1979 election as an Independent Labor candidate, but was defeated.