After obtaining his BA degree in 1951, he worked for an insurance company, and later joined newspapers where he used to write columns on various subjects.

He wrote first-ever film review in Afaq newspaper and then chose it as a regular job.

Following the 1958 Pakistani coup d'état, he left journalism and moved to film industry.

[3] He first joined the Urdu cinema as a storywriter and later wrote dialogues for Aadmi and Ayyaz films.

[3][4][5] He was suffering from health complications over the past few years and died in Lahore, Pakistan on 27 January 2015 of cancer.