After spells with East Stirlingshire, Vale of Garron and Stoke, Smith joined West Bromwich Albion in 1900.
[2] He had a brief spell with Newton Heath early in 1903, before joining Bristol Rovers the same year.
[3] While at Bristol Rovers he won a Southern League title in the 1904–05 season, when he was also the division's top goalscorer.
[4] He ended his career in the midlands, playing firstly for Wednesbury Old Athletic, then finally Brierley Hill Alliance.
After finishing his footballing career he returned to his native Scotland, where he worked in a steel factory and as a docker.