A goalkeeper, he began his career at local side Abercynon before signing for Cardiff City at the end of World War II.
[6] He continued as first choice goalkeeper the following season in Division Two but was allowed to leave the club in January 1949 to sign for their local rivals Swansea Town for £3,000.
[7] He spent two years at Swansea, competing with Jack Parry to be first choice goalkeeper, winning the Division Three South title for the second time in his career during the 1948–49 season.
In July 1951, Canning was sold to Nottingham Forest for £2,000 but struggled to break into the first team, making just five league appearances, and left the club soon after, moving into non-league football.
[8] Following his retirement from football, Canning began working as an apprentice toolmaker and went on to become an electronics engineer, designing military equipment.