On 24 January 2016, Weir left Glasgow to join 1872 Cup rivals Edinburgh on a two-year deal from the 2016-17 season.

[4] After racking up 221 points in 30 games during his time at BT Murrayfield Stadium, he left Edinburgh to join English side Worcester Warriors in the Premiership Rugby on a one-year deal.

[6] On 13 January 2021, Weir returned home to Scotland to re-join Glasgow Warriors which started his professional career ahead of the 2021-22 season.

Weir was called up to Scotland’s extended Six Nations squad in 2019 after an outstanding first season with Worcester Warriors.

His consistent form coupled with Scotland’s decision to suspend Finn Russell for a breach of team protocols led to another recall ahead of the 2020 Six Nations.