He was born in Quarryville, Pennsylvania, and attended Franklin and Marshall College, receiving a B.S.

During World War II, he served as a lieutenant in the United States Coast Guard.

After the war, he taught school then was elected to the Pennsylvania House of Representatives, serving from 1954 to 1966.

He was elected in 1966 to the 90th Congress, representing the 16th Congressional District in southcentral Pennsylvania.

Retiring for health reasons after 5 terms, he endorsed and was succeeded in Congress by his administrative assistant and chief of staff, Robert Smith Walker.