[3] In 1824, when Moir was working on an article for the Edinburgh Review, a friend suggested that he might seek information from Sir William Hamilton.
[3] In the 1830s, he made the acquaintance of Thomas Carlyle who found him "become a conservative, settled everywhere into dilettante, not very happy, I think; dry, civil, and seems to feel unheimlich in my company".
He continued in practice at the Scottish bar, and in 1855 was appointed sheriff of Ross and Cromarty, a post which in 1859 he exchanged for the shrievalty of Stirlingshire.
In 1864 the Faculty of Advocates chose Moir as Professor of Scots law at the University of Edinburgh, however due to bad health he resigned in less than a year.
His works are:[2] Extracts from Moir's lectures were incorporated by William Guthrie in the 14th edition of John Erskine's Principles of the Law of Scotland, 1870.