Born in Lambeth, London, Moir began his boxing career whilst serving in the British Army in India.

[1] He was trained by the trainer Dai Dollings and the wrestler Sid Grumley from Shepherds Bush.

[14] In 1922 he was fined £500 for slander after allegations regarding motor-lamp maker William Nelson and Moir's son, James.

[14] He wrote an instructional book, The Complete Boxer, which was published in 1930, and subsequently took up acting, appearing in films such as Third Time Lucky (1931), Madame Guillotine (1931), and The Mystery of the Mary Celeste (1935).

[11][12][17][18] He died on 12 June 1939 in hospital in Sutton, Surrey after a long illness, aged 60.