After completing intermediate education from Islamia College, Peshawar, he was one of the 25 people selected from British India for the first course at the Indian Military Academy, Dehradun.

He was mentioned in dispatches for service in Burma in the London Gazette 10 January 1946 as temporary Major, Bihar Regiment.

[5] In December 1958, he graduated from the Imperial Defence College, London (now the RCDS) and was promoted to lieutenant general rank and appointed as Deputy C-in-C of the Pakistan Army.

He was also presented with the Legion of Merit by the President of the United States authorised by act of Congress for exceptionally meritorious conduct.

He also served as a federal minister during Zia-ul Haq's time and made an abortive attempt to contest elections from his home constituency of Karak.