[1] Carroll served in the 13th and 14th Infantry of the New York National Guard, and during the Spanish–American War he was a private in the United States Army Hospital Corps.
[2] In 1919, Carroll was elected to the New York State Assembly as a Republican, representing the Kings County 9th District.
In 1920, he was chairman of a conference of 31 service men that considered and promoted World War I veterans' welfare measures.
[2] Carroll was prominently involved in the United Spanish War Veterans in Brooklyn, serving as head of the organization in Kings County in 1916.
His wife's name was Daisy, and his children were Mrs. Richard A. McCormack, Mrs. William A. Duffy, Mrs. Edward Michaels, Mrs. James Traidor, May, Charles A., and Paul.