Born in Kilbirnie, in North Ayrshire, Scotland, he spent the majority of his career in England where he played for Barnsley, Sheffield United and Leicester Fosse in The Football League.
Lang had been playing for local Glasgow sides Co-op United and Govern when he was signed by Barnsley in August 1902.
[1] Making his Football League debut against Stockport County in September 1902, Lang stayed less than a season with the Yorkshire club, joining their local rivals Sheffield United for a £75 transfer fee in March 1903.
[1] Lang's stay at Leicester was only a brief one and he was released in the summer of 1910, returning to Yorkshire to work as a miner while playing non-league football for Denaby United.
[1] By 1905 Lang was near to a call up for Scotland, playing in an Anglo–Scots Vs Home-Scots fixture in March of that year, but his injury problems meant that he failed to break into the national team.