He was educated at Christian Brothers College in East Melbourne, then spent three years raising stock for his father.
In 1895 he emigrated to Western Australia, where he spent the next twelve years as a prospector.
He held the seat until the election of 4 November 1914, by which time he was living at Highgate.
McDonald returned to Victoria in 1914, joining the Liquor Trades Union and obtaining work in a soft drink factory.
Thereafter he was assistant secretary of the union from July 1921 until his death on 19 June 1934.