He was born on 19 July 1850 in Edinburgh, his father a shawl manufacturer who was bankrupted in 1857, his mother dying at his birth.
[2][1] In 1884 he was appointed first curator of the new Scottish National Portrait Gallery, initially at temporary premises and later in Robert Rowand Anderson's Queen Street building, which opened in 1889.
[1] He wrote regularly for periodicals including Academy and the Edinburgh Evening Courant and was chief art critic of the Scottish Leader.
[3] His publications included an 1880 book on Scottish artist George Manson and several essays on the iconography of Robert Burns.
He died on 22 March 1894 of a brain haemorrhage, shortly before his 44th birthday, and was buried at Echo Bank cemetery in Newington, Edinburgh.