He began his career in the Parliament of South Australia (1893–1906) and served two terms as Commissioner of Public Works in liberal and conservative governments.

Foster was born in Goodmanham, Pocklington, Yorkshire, England and educated at Prospect House, Tockwith and apprenticed to a draper.

[1] He was Commissioner for Public Works from 8 December 1899 to 4 July 1904[1] and Minister for Industry from 1902 to 1904 in the liberal governments of Frederick Holder and John Jenkins.

He resigned from the ministry in 1904, but still supported Jenkins until it fell in 1905 and was then Commissioner for Public Works and Minister for Agriculture in the conservative administration of Richard Butler, but lost his seat in 1906.

[2] Foster died in the Adelaide suburb of St Peters on 5 January 1932, survived by his wife, three daughters and a son.