He participated in the Northern Expedition of the National Revolutionary Army, and the Central Plains War.

During World War II, he became the General-in-Chief of the 4th Group Army, and also held many other important military positions.

He led his troops fought at the Baoding, Xi Kou, and Mountain of Zhong Tiao.

From 1938 to the end of World War II, with inferior weapons, comparable numbers, but superior tactics, he successfully stopped the Japanese army who had much more superior weapons during his battles in Northwest China, and is therefore considered one of the most important Generals who defended Northwest China from the Japanese armies in World War II.

After the establishment of the People's Republic of China, he worked as the vice Governor of Shaanxi province and other administrative positions.