Born in Aiken, South Carolina, Croft attended the common schools.

He graduated from Bethel Military Academy in Warrenton, Virginia in 1895 and from the law department of the University of South Carolina at Columbia in 1897.

While in Congress, he carried on his father's idea of building a post office in downtown Aiken.

He was assigned to duty as a private in the Field Artillery Central Officers' Training School, Camp Zachary Taylor, and served until December 5, 1918, when he was honorably discharged.

He died in Aiken, South Carolina, March 23, 1920 and was interred in St. Thaddeus' Episcopal Churchyard.