Shanks was born in Wexford and started his playing career with local club Wexford before moving to England to play for Derby West End and then Derby County in 1898.

[3] He spent three seasons at the Baseball Ground, playing 28 times and scoring 9 goals, but could not hold down a regular place.

[5] He made his Arsenal debut against Burslem Port Vale on 10 January 1903 and went on to be a regular that season as an inside forward, scoring five times.

[3] His performances for his club earned him the first of three caps for Ireland, against Scotland on 21 March 1903.

[5] In 1909 he moved back to London to play for Leyton and saw out his career at Clapton Orient and York City.