In 1784 he discharged the duties of advocate-depute along with Robert Blair and Alexander Abercromby; and in 1787 he became sheriff-depute of Ayrshire.
For most of his life he lived on the west side of George Square in southern Edinburgh (then a new building) but he moved to York Place in the New Town when it was first built.
Craig's cousin, Robert Burns' muse, Agnes Maclehose, commonly known as "Clarinda" is buried next to him.
Craig was one of a group of advocates in literary society called the "Tabernacle", who met in a tavern to read essays.
After Henry Mackenzie the contributions of Craig were the most numerous, including a paper on the poems of Michael Bruce, in No.