Zhang Dingfan, (Chinese: 张定璠; 1891 – 25 January 1945) alternate name Zhang Boxuan 张伯璇, was a Chinese military general, police officer, and politician who cut his teeth during the 1911 Revolution in Wuchang and successively rose to the rank of General throughout the various civil wars of the 1920s to the Japanese invasion of World War II.

Zhang Dingfan was born in Nanchang city in Jiangxi Province (江西南昌) to a merchant family.

He shortly left the Academy to join the Wuchang Uprising, catalyst for the Xinghai 1911 Revolution.

Following the success of the Revolution, he returned to study at the Wuchang Military Institute and graduated from the affiliated Baoding Officer Academy, to be commissioned as a company commander in the Jiangxi 4th Army.

He returned in 1937 as the Japanese Invasion accelerated and became the First Deputy Head of the Nationalist Military Affairs Commission.

Nevertheless, Bai's armies were critical in the success of Chiang's two Northern Expeditions forming the left and center of the advances.

Zhang was a field general they both depended upon and was rewarded to be the Mayor of Shanghai while remaining in command of the 13th Army in the heart of China.

When that war began in ernest, Chiang Kai-shek recalled Zhang to the Military Affairs Commission and promoted him as well.