He worked in the milling business for J.B. Miller & Son before being elected the school director for Washington Township from 1883 to 1891.

Then he was elected chief burgess, an office akin to mayor, of Bangor, Pennsylvania from 1896 to 1899.

He was elected as a Democrat to the Pennsylvania House of Representatives in 1898 and 1900 and chose not to seek re-election in 1902.

He subsequently served on the Bangor borough council from 1905 to 1910 and was then elected to the Pennsylvania State Senate.

Miller died on February 11, 1947, in Pen Argyl, Pennsylvania and was buried in St. John's Cemetery in Bangor.