He is very well known for some of the most memorable box office hit films from the 1960s to 1980s such as Do Bhai, Yeh Raat Phir Na Aaygi, Ustadon Ke Ustad, Night In London, Victoria No.
He was married to Hindi film actress, Sayeeda Khan (also known as Sudha Sadanah).
In the early 1980s, he suffered a major setback when some of his films turned out to be major flops at the box office like Oonche Log, Bombay 405 Miles and Magroor.
The string of flops ended with the success of Taqdeer and Mardonwali Baat.
While inebriated, he fatally shot himself after killing his wife and daughter, on his son Kamal's birthday.