Born in Leeds, McNiven was raised in Lytham St Annes, Lancashire, where he played junior football for the Y.M.C.A.

He made a late substitute appearance for Morecambe in the 2006–07 Conference National play-off final win at Wembley Stadium against Exeter City.

[5] On 8 October 2008 he was due to join Fleetwood Town on a one-month loan deal,[6] however injuries at Stafford Rangers meant he did not sign.

[7] He left Stafford in the summer of 1945 to move closer to his Lancashire home,[8] joining Hyde United, becoming one of a number of signings made by manager Neil Tolson ahead of the 2009–10 season.

[14] McNiven's father (also called David) was also a professional footballer as is his twin brother, Scott, who plays for the same club.