He started his career as an editor for Don Muthu Swami and as a director in Yeh Jo Mohabbat Hai.
[3] His second directorial was Toilet: Ek Prem Katha and it starred Akshay Kumar and Bhumi Pednekar.
The film was produced by Ajit Andhare and Prernaa Arora, under the banner of Viacom 18 Motion Pictures and KriArj Entertainment.
[4][5] Singh was nominated for Filmfare awards under the best director category for the film Toilet: Ek Prem Katha.
[6] In February 2018, it was announced that Singh would be directing Batti Gul Meter Chalu which stars Shahid Kapoor, Shraddha Kapoor and Yami Gautam in lead roles and is produced by Bhushan Kumar and Krishan Kumar under T-Series and Prernaa Arora under KriArj Entertainment.