[1] Miller made his first-class debut in the Dolphins' final game of the 2007–08 domestic SuperSport Series, scoring a half-century in the first innings in which he batted.

Miller made eight appearances in the one-day MTN Domestic Championship competition of the same season, though his final match was abandoned after just three overs.

[4][5] In October 2018, Miller was named in Durban Heat's squad for the first edition of the Mzansi Super League T20 tournament.

On 6 May 2013, Miller hit the third fastest hundred in IPL history, scoring 101 not out off 38 balls in a chase against Royal Challengers Bangalore, at Mohali.

He was retained by Kings XI Punjab for 2014 IPL where he played all matches and help his team to reach the finals.

[19] In June 2023 Miller was added to the Texas Super Kings roster for the inaugural season of Major League Cricket.

[20] Miller earned his national call up in May 2010 after a series for South Africa A against Bangladesh A, where he ended as the second-highest run-scorer.

Miller, called up to replace the injured Jacques Kallis, dispatched the sixth ball of his innings for six and went on to top score as South Africa won by just 1 run.

He played in two ODI series, against West Indies and Pakistan, before being named in South Africa preliminary 2011 World Cup squad.

[24][25] On 15 October 2010, Miller made his maiden ODI fifty against Zimbabwe and South Africa went on to put a massive total of 351.

[27] In August 2017, Miller was named in a World XI side to play three Twenty20 International matches against Pakistan in the 2017 Independence Cup in Lahore.

[28] Miller was one of South Africa's top performers at the 2015 Cricket World Cup scoring 324 runs at an average of 65 and strike rate of 139 during the tournament.

[44] Miller was one of South Africa's top performers at the 2023 Cricket World Cup scoring 356 runs at an average of 45 and strike rate of 108 during the tournament.