He began his football career with Edinburgh Emmett and then came to England to sign for Birmingham of the First Division in August 1924.
He played only once for Birmingham, deputising for the injured Jimmy Cringan and his regular understudy Bill Hunter at centre half in a 4–0 defeat at Sunderland on 6 September 1924.
[3][4] After a brief spell in non-league football with Redditch Town he settled at Doncaster Rovers, where he played 150 Third Division North games in four seasons.
[2] After one Second Division game in one and a half seasons for Bristol City,[5] a return to the Third with Barrow offered more playing time.
Short spells with Walsall and Southport and a venture to Ireland with Brideville preceded a return to non-league football in the English Midlands with Worcester City and Atherstone Town.