He was a professor of music at the Pennsylvania Military Academy for twenty-five years and collaborated with William J. Kirkpatrick to produce and publish over 1,000 gospel hymn songs and over sixty hymnal books.

He was born in West Chester, Pennsylvania, and showed indications of musical ability at an early age.

After returning from the war he was appointed Professor of Music at the Pennsylvania Military Academy,[4] then located at West Chester.

[5] About 1869 he was recalled to the Pennsylvania Military Academy, and moved to Chester, where he was professor of music in that institution for twenty-five years.

His most popular and widely known hymn is "Beulah Land" His first Sunday-school book, the "Gems of Praise," was issued in annual numbers beginning in 1871 and finished in 1876.

He was then associated largely with William J. Kirkpatrick in issuing the following books: "The Garner," "The Quiver," "The Ark of Praise," "Songs of Redeeming Love—Nos.